Messages in this thread | | | Date | Fri, 14 Jan 2000 23:16:54 -0800 (PST) | From | Linus Torvalds <> | Subject | Re: [Patch] Cleanup struct gendisk registration, 2.3.40-pre1 |
| |
On Sat, 15 Jan 2000, Alexander Viro wrote: > > Linus, your comments? I'ld rather do > drop_partitions() one as incremental to that...
Hmm.. Looks ok to me, have you been able to test some SCSI and IDE cases with this?
Also, I'm as big a fan of Stranger in a Strange Land as anybody else, but that doesn't really mean that I think "grok_partitions()" is necessarily the best name. How about just "parse_partitions()" or something, I don't think the code really meets the required level of intimate and consummate understanding of partitions to call it "grok"..
Linus
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
| |