Messages in this thread | | | Date | Wed, 12 Jan 2000 15:52:36 +0000 (GMT) | From | Tigran Aivazian <> | Subject | Re: [idea] request_module(const char *fmt, ...); |
| |
On Wed, 12 Jan 2000, Andreas Schwab wrote: > |> On Tue, 11 Jan 2000, Alexander Viro wrote: > |> > Another thing being that yes, it would be nice to have printf-like _real_ > |> > request_module(). The only thing to watch for is literal module name > |> > passing - if you know that name will never contain % you are fine, > |> > otherwise you'll need to go for "%s",name. > > Unless "hello" is "h%ell%o", or some non-literal.
I admited that Alexander's point is valid. But I don't think request_module() should work around that - it is better to document module names containing % character as invalid. A non-privileged user can't do anything nasty here so I don't see any problem. Let's document it in some obscure place so the luser (or lprogrammer?) who wrote a module called "h%ell%o" spends hours finding out why it is not autoloaded... ;)
Regards, Tigran.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
| |