lkml.org 
[lkml]   [1999]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: Proposed patch tty_io.c/8K write split
Date
From: <Fabian.Frederick@prov-liege.be>

> -> + if ( test_bit(TTY_NO_WRITE_SPLIT, &tty->flags) )
>
> Why playing with flags here ?...
> if (!count%8192)
> /*process one frame UNINTERRUPTIBLE*/
> -> + written = write(tty, file, buf, count);
> /*Check 'written' here not below ....
> that's one test non 8K condition won't race. */
>

Your proposed check avoids splitting writes if the
size of the write is an even multiple of 8K. Writes
larger than 8K will still be split if not an even multiple
of 8K.

The intent of the original patch (with the flag) is to
prevent *any* splitting of the write, such that the
line discipline can process the entire write at once.
Also, when the flag is not set, I want the behavior
to be exactly the same as before : the write will
*always* be split when larger than 8K.

Thanks,
Paul

Paul Fulghum paulkf@microgate.com
Microgate Corporation www.microgate.com
9501 Capital of Texas Hwy
Austin, Texas 78759
(512)-345-7791



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:53    [W:0.027 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site