Messages in this thread | | | From | "Paul Fulghum" <> | Subject | Re: Proposed patch tty_io.c/8K write split | Date | Tue, 24 Aug 1999 12:12:52 -0500 |
| |
From: <Fabian.Frederick@prov-liege.be>
> -> + if ( test_bit(TTY_NO_WRITE_SPLIT, &tty->flags) ) > > Why playing with flags here ?... > if (!count%8192) > /*process one frame UNINTERRUPTIBLE*/ > -> + written = write(tty, file, buf, count); > /*Check 'written' here not below .... > that's one test non 8K condition won't race. */ >
Your proposed check avoids splitting writes if the size of the write is an even multiple of 8K. Writes larger than 8K will still be split if not an even multiple of 8K.
The intent of the original patch (with the flag) is to prevent *any* splitting of the write, such that the line discipline can process the entire write at once. Also, when the flag is not set, I want the behavior to be exactly the same as before : the write will *always* be split when larger than 8K.
Thanks, Paul
Paul Fulghum paulkf@microgate.com Microgate Corporation www.microgate.com 9501 Capital of Texas Hwy Austin, Texas 78759 (512)-345-7791
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
| |