Messages in this thread | | | Date | Wed, 14 Jul 1999 15:46:03 +0200 | From | Jan Kasprzak <> | Subject | Re: [patch] syncppp.c and skb->priority |
| |
Gergely Madarasz wrote: : : > BTW, I have found another problem with syncppp.c. In Sync PPP mode : > it does not work when I manually ifconfig one of the ends down and then up. : > It seems the LCP does not end. It helps to unplug the line physically : > for MAXALIVECNT keepalive packets - both ends then will agree the line : > is down and restart the LCP from the beginning. : : Hmm... sorry, can't help you with this one. It should be related with your : board not reporting modem line status though. The driver should be : notified of modem line status changes and call at least sppp_reopen() when : the line changes to up. In my drivers I even call sppp_close() when the : line goes down and sppp_open() when it comes back. : I don't agree - the line can be for example noisy enough for making one of the ends loosing MAXALIVECNT keepalive packets and re-starting LCP, while the other end thinks it is already up. My opinion is, that syncppp.c should be able to recover from this situation cleanly.
I will look at it when I come back.
-Yenya
-- \ Jan "Yenya" Kasprzak <kas at fi.muni.cz> http://www.fi.muni.cz/~kas/ \\ PGP: finger kas at aisa.fi.muni.cz 0D99A7FB206605D7 8B35FCDE05B18A5E // \\\ Czech Linux Homepage: http://www.linux.cz/ /// The new code base has not stabilized enough yet for benchmarking. Be patient, we'll be sure to delay NT5's release a bit, trust me... (DaveM)
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
| |