lkml.org 
[lkml]   [1999]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] pagecache-2.3.9-E8, fixes against pre3-2.3.9

On Fri, 25 Jun 1999, Andrea Arcangeli wrote:

> I had a fast review of your patch and I think you missed a
> page-cache-corruption bug that I fixed in my buffer patch sent one hour
> ago.

(i'll check it out and integrate it into the cleanup patch.)

> > [David also removed the reuse_list (noticed by V Ganesh), and i removed
> > BH_protected logic, these two were obsolete concepts.]
>
> I don't think the protected bit is obsolete. It still make sense for the
> metadata. And it will forbid shrink_mmap to release the page since now the
> page is the backend of the ramdisk. We only need to clear the protected
> bit in flushpage for truncate (exactly where now we wait for the buffer to
> complete I/O before marking it clean and freeing it). Then the ramdisk
> should be near to work again.

the ramdisk driver just needs to increate bh->b_count to 1, and nobody
will ever free the page - do you see any problem with that?

Ingo


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:52    [W:0.077 / U:1.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site