Messages in this thread | | | Date | Fri, 25 Jun 1999 14:00:18 -0400 (EDT) | From | Benjamin LaHaise <> | Subject | Re: [patch] pagecache-2.3.9-E8, fixes against pre3-2.3.9 |
| |
On Fri, 25 Jun 1999, Ingo Molnar wrote:
> how should i clean it up? When we allocate a new block we have three > (conceptual) parameters 'got new block', 'block address' and 'error > condition'. I couldnt reduce it further. I did not want to duplicate code > and put a whole block_write_partial|full_page implementation just to be > able to pass bhs to the lowlevel fs. This just hides the parameter passing > problem, N times, into every block-based filesystem. It also eliminates > clean ways to merge the 'clear new block' operation with 'overwrite block > contents'.
Here's what I think is a simple way to work around that: bmap_create should only be used to create the mapping. If it already exists, return -EEXISTS, and let the calling code can deal with calling the normal bmap function to find out what block is in use. Does that sound reasonable?
-ben
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
| |