Messages in this thread | | | Date | Sat, 29 May 1999 21:17:27 -0700 (PDT) | From | Jeremy Katz <> | Subject | Re: ia64: Patch 2.3.4pre1 looks fishy |
| |
On Thu, 27 May 1999, Horst von Brand wrote:
> I have no idea what is going on here, but this doesn't look right: > > diff -u --recursive --new-file v2.3.3/linux/fs/open.c linux/fs/open.c > --- v2.3.3/linux/fs/open.c Fri Apr 16 14:21:39 1999 > +++ linux/fs/open.c Mon May 24 22:47:43 1999 > @@ -171,7 +171,7 @@ > return error; > } > > -#ifndef __alpha__ > +#if !(defined(__alpha__) || defined(__ia64__)) > > /* > * sys_utime() can be implemented in user-level using sys_utimes(). > > The last #if is supposed to match if __alpha__ is not defined, but __ia64__ > is. This is absurd, AFAIU they can't ever be both defined. >
Maybe I'm an idiot (it wouldn't be the first time :) but doesn't it match as long as neither alpha or ia64 defined? That is, some code which the arches other than alpha and ia64 need. (hmmm... how much similarity is there between ia64 and alpha I wonder...)
Jeremy
-- Jeremy Katz http://linuxpower.org
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
| |