lkml.org 
[lkml]   [1999]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [CFT] rename patch (2.2.3)


On 9 Mar 1999, Trond Myklebust wrote:

> Alexander Viro <viro@math.psu.edu> writes:
>
> > Folks, I've rediffed rename patch against 2.2.3 and had put it to
> > ftp://ftp.math.psu.edu/pub/viro/rename-patch-9.gz
> > There were no changes since the moment when 2.2.2 came out
> > (actually even earlier). I run it here and I consider it a stable code (at
> > least as stable as the current code in the kernel). AFAIC it is the final
> > variant. I'm submitting it to Linus.
>
> Why have you removed the name length checking from the NFS code? That
> is wrong, and should in any case not be a change for a stable version.

Huh??? It is done in nfs_lookup() and there is no way for dentry to become
hashed and/or be passed to methods without ->lookup() approving it. All
static checks (e.g. name length if the limit can't change) are done there.
All methods except ->lookup() get dentries already in dcache, positive or
negative. If lookup() refused to call d_add() and returned an error dentry
will be silently dropped and will never make its way to other methods.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:50    [W:0.058 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site