lkml.org 
[lkml]   [1999]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] sleep_on() fixes, 2.2.3-1
On Sat, 6 Mar 1999, Ingo Molnar wrote:

>+#define wait_event_cli(wq, condition) \
>+ wait_event(wq, \
>+ ({ \
>+ int __ret; \
>+ cli(); \
>+ __ret = condition; \
>+ sti(); \
^^^^^ this should be a restore_flags() according to me,
but looks like we need sti() to don't deadlock in the subtle
write_lock-way you Ingo discovered. I think we could remove the _cli
version of the wait_event macro, if somebody need some locking he can
call wait_event in a custom way as you did in wait_event_cli() itself.

>+#define __wait_event_interruptible(wq, condition) \

Here I think we could add a third param to the macro, that will be the
retval in the interrupted case. It's zero cost and looks nicer to me.

Andrea Arcangeli


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:50    [W:0.050 / U:1.440 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site