[lkml]   [1999]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: select()/socket has problems under 2.2.x.
    Date (Andrea Arcangeli) writes:
    > }
    > } else if (TCP_SKB_CB(skb)->ack_seq == tp->snd_una &&
    > - atomic_read(&sk->rmem_alloc) <= sk->rcvbuf) {
    > + (sock_rspace(sk) ||
    > + (!skb_queue_len(&sk->receive_queue) &&
    > + !skb_queue_len(&tp->out_of_order_queue)))) {
    > /* Bulk data transfer: receiver */
    > __skb_pull(skb,th->doff*4);

    The out_of_order_queue check is bogus because the fast path should be never
    entered when there are ooo packets. Also you just introduced a costly
    additional function call with useless checking (sk!=NULL etc.) to an
    important fast path. Why should we go through all the hazzles of header
    prediction, if all benefits are later destroyed by lazy coding like this?

    I also don't see what you're trying to archieve with this change.


    This is like TV. I don't like TV.

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    Please read the FAQ at

     \ /
      Last update: 2005-03-22 13:50    [W:0.020 / U:224.592 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site