lkml.org 
[lkml]   [1999]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[Patch] Re: 2.2.4 compile failure
It seems acct.c was changed to use the less-deprecated filp_close
function, and the arguments weren't changed.

A patch is attached, I haven't had any problems so far.
--------------------------
General notions are generally wrong.
-- Lady M.W. Montagu
On Wed, 24 Mar 1999 root@7of9.capsi.cx wrote:

> + The error:
>
> acct.c: In function `sys_acct':
> acct.c:197: too few arguments to function `filp_close'
> acct.c:203: too few arguments to function `filp_close'
> make[2]: *** [acct.o] Error 1
> make[2]: Leaving directory /usr/src/linux/kernel'
> make[1]: *** [first_rule] Error 2
> make[1]: Leaving directory /usr/src/linux/kernel'
> make: *** [_dir_kernel] Error 2
>
> + The grep:
>
> 7of9:/usr/src/linux# grep filp_close */*.c
> fs/binfmt_aout.c: filp_close(file, NULL);
> fs/binfmt_elf.c: filp_close(file, NULL);
> fs/open.c:int filp_close(struct file *filp, fl_owner_t id)
> fs/open.c: error = filp_close(filp, files);
> kernel/acct.c: filp_close(old_acct);
> kernel/acct.c: filp_close(file);
> kernel/exit.c: filp_close(file, files);
> kernel/ksyms.c:EXPORT_SYMBOL(filp_close);
>
> + The system:
>
> uname -a:
> Linux 7of9 2.2.3 #9 Tue Mar 9 16:17:56 CET 1999 i586 unknown
> gcc -v:
> Reading specs from /usr/lib/gcc-lib/i586-pc-linux-gnulibc1/egcs-2.90.29/specs
> gcc version egcs-2.90.29 980515 (egcs-1.0.3 release)
> make -v:
> GNU Make version 3.76.1, by Richard Stallman and Roland McGrath.
>
> +
>
> Rob
> --
> Rob Kaper | mail: cap@capsi.com + cap@capsi.net + cap@capsi.cx
> | web: http://capsi.com/ + http://capsi.cx/ - icq: 707085
> | "Got up early (as in before noon). A most confusing experience
> | when the sun is coming up not going down." -- Alan Cox
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.rutgers.edu
> Please read the FAQ at http://www.tux.org/lkml/
>
--- original/linux/kernel/acct.c Mon Mar 22 13:08:50 1999
+++ linux/kernel/acct.c Tue Mar 23 19:25:44 1999
@@ -194,13 +194,13 @@
}
if (old_acct) {
do_acct_process(0,old_acct);
- filp_close(old_acct);
+ filp_close(old_acct, NULL);
}
out:
unlock_kernel();
return error;
out_err:
- filp_close(file);
+ filp_close(file, NULL);
goto out;
}
\
 
 \ /
  Last update: 2005-03-22 13:50    [from the cache]
©2003-2011 Jasper Spaans. Advertise on this site