lkml.org 
[lkml]   [1999]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: [2.2.2] The difference between sk_filter and sock_filter?
From
Date
werner@suse.de (Dr. Werner Fink) writes:

> Hi,
>
> there is trouble with the option CONFIG_FILTER. The structure
> sk_filter used with patch 2.2.2 isn't defined in any header. Only the
> struct sock_filter is given in include/linux/filter.h.
> It looks like sk_filter and sock_filter are different structures because
> the sk_run_filter call in include/net/sock.h uses the entries insns and
> len of that new structure.

[...]


Somehow the filter.h part of the LPF fixes got lost. Here is it.
Linus, could you please apply it?


-Andi

diff -ur linux-2.2.1/include/linux/filter.h linux/include/linux/filter.h
--- linux-2.2.1/include/linux/filter.h Mon Dec 22 04:41:24 1997
+++ linux/include/linux/filter.h Wed Feb 3 23:16:48 1999
@@ -18,18 +18,32 @@

struct sock_filter /* Filter block */
{
- u16 code; /* Actual filter code */
- u8 jt; /* Jump true */
- u8 jf; /* Jump false */
- u32 k; /* Generic multiuse field */
+ __u16 code; /* Actual filter code */
+ __u8 jt; /* Jump true */
+ __u8 jf; /* Jump false */
+ __u32 k; /* Generic multiuse field */
};

struct sock_fprog /* Required for SO_ATTACH_FILTER. */
{
- unsigned short len; /* Number of filter blocks */
+ unsigned int len; /* Number of filter blocks */
struct sock_filter *filter;
};

+#ifdef __KERNEL__
+struct sk_filter
+{
+ atomic_t refcnt;
+ unsigned int len; /* Number of filter blocks */
+ struct sock_filter insns[0];
+};
+
+extern __inline__ unsigned int sk_filter_len(struct sk_filter *fp)
+{
+ return fp->len*sizeof(struct sock_filter) + sizeof(*fp);
+}
+#endif
+
/*
* Instruction classes
*/
@@ -86,21 +100,40 @@
#define BPF_TAX 0x00
#define BPF_TXA 0x80

-#define BPF_MAXINSNS 512
+#ifndef BPF_MAXINSNS
+#define BPF_MAXINSNS 4096
+#endif

/*
* Macros for filter block array initializers.
*/
+#ifndef BPF_STMT
#define BPF_STMT(code, k) { (unsigned short)(code), 0, 0, k }
+#endif
+#ifndef BPF_JUMP
#define BPF_JUMP(code, k, jt, jf) { (unsigned short)(code), jt, jf, k }
+#endif

/*
* Number of scratch memory words for: BPF_ST and BPF_STX
*/
#define BPF_MEMWORDS 16

+/* RATIONALE. Negative offsets are invalid in BPF.
+ We use them to reference ancillary data.
+ Unlike introduction new instructions, it does not break
+ existing compilers/optimizers.
+ */
+#define SKF_AD_OFF (-0x1000)
+#define SKF_AD_PROTOCOL 0
+#define SKF_AD_PKTTYPE 4
+#define SKF_AD_IFINDEX 8
+#define SKF_AD_MAX 12
+#define SKF_NET_OFF (-0x100000)
+#define SKF_LL_OFF (-0x200000)
+
#ifdef __KERNEL__
-extern int sk_run_filter(unsigned char *data, int len, struct sock_filter *filter, int flen);
+extern int sk_run_filter(struct sk_buff *skb, struct sock_filter *filter, int flen);
extern int sk_attach_filter(struct sock_fprog *fprog, struct sock *sk);
#endif /* __KERNEL__ */


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:50    [W:0.030 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site