Messages in this thread Patch in this message | | | Date | Thu, 9 Dec 1999 11:59:43 +0000 (GMT) | From | Tigran Aivazian <> | Subject | (FIXED!) Re: 2.3.32-pre2 panic on boot in tlan.c:TLan_EeReadByte() |
| |
Hi,
it was a trivial bug (spin_lock_init() was in init_module but not in tlan_probe())- see the patch below. Btw, (again I did not look at it closely, but) why is tlan_probe() and init_module() contain so much duplicate code? Someone needs to cleanup tlan.c... (just noticed it is Orphan in MAINTAINERS)
--- drivers/net/tlan.c Thu Dec 9 12:47:55 1999 +++ ../2332-pre2/drivers/net/tlan.c Thu Dec 9 10:47:29 1999 @@ -489,7 +489,7 @@ } priv->sa_int = dev->mem_start & 0x02; priv->debug = dev->mem_end; - spin_lock_init(&priv->lock); + printk("TLAN %d.%d: %s irq=%2d io=%04x, %s, Rev. %d\n", TLanVersionMajor,
Regards, ------ Tigran A. Aivazian | http://www.sco.com Escalations Research Group | tel: +44-(0)1923-813796 Santa Cruz Operation Ltd | http://www.ocston.org/~tigran On Thu, 9 Dec 1999, Tigran Aivazian wrote:
> Hi, > > simply booting 2.3.32-pre2(+kdb) causes this: > > sym53c876-0-<4,*>: FAST-20 WIDE SCSI 40.0 MB/s (50 ns, offset 15) > SCSI device sda: hdwr sector= 512 bytes. Sectors= 8386000 [4094 MB] [4.1 > GB] > TLAN 1.0: eth1 irq=30 io=2800, Compaq Netelligent Integrated 10/100 TX > UTP, Rev. 16 > eip: c01ceb50 > kernel BUG at /usr/src/linux/include/asm/spinlock.h:78! > Entering kdb on processor 1 due to panic @ 0xc01ceb7c > eax = 0x00000038 ebx = 0xc115dc48 ecx = 0xc0243b8c edx = 0xc0243b8c > esi = 0xc02563e0 edi = 0xc115db60 esp = 0xc0227b06 eip = 0xc01ceb7c > ebp = 0xc116bef8 ss = 0xc0227ae0 cs = 0x00000010 eflags = 0x00010082 > ds = 0x00000018 es = 0x00000018 origeax = 0xffffffff ®s = > 0xc116bea0 > > The eip=c01ceb50 corresponds to TLan_EeReadByte() so looks like > spin_lock_init() inline was compile as if without SPINLOCK_DEBUG (which is > impossible because tlan.c includes <linux/spinlock.h> which includes > <asm/spinlock.h> which defines SPINLOCK_DEBUG 1) but I did not have a > close look (just a "comment in passing") > > > Hope this helps, > ------ > Tigran A. Aivazian | http://www.sco.com > Escalations Research Group | tel: +44-(0)1923-813796 > Santa Cruz Operation Ltd | http://www.ocston.org/~tigran > > > > >
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
| |