Messages in this thread | | | Subject | Re: wait_on_irq, CPU1 | Date | Wed, 29 Dec 1999 22:31:38 -0300 | From | Horst von Brand <> |
| |
Andi Kleen <ak@suse.de> sagte: > On Wed, Dec 29, 1999 at 12:47:01PM -0600, Bill Wendling wrote: > > } + module_start = PAGE_OFFSET + (max_mapnr << PAGE_SHIFT); > > } + module_start = ((module_start + VMALLOC_OFFSET) & ~(VMALLOC_OFFSET-1)); > > } + > > } + i = 1; > > } + while (((long) stack & (8192-1)) != 0) { > > ^^^^ > > Would it be a better idea to use a #defined value here (and in other > > places) such as THREAD_SIZE to avoid confusion? Just a suggestion.
> THREAD_SIZE is not defined in 2.2, only in 2.3. The code needs to work > under 2.2.
In that case, do a:
#ifndef THREAD_SIZE #define THREAD_SIZE 8192 #endif
The code had better be readable. The above can then be removed later, and won't do any harm anyway. -- Horst von Brand vonbrand@sleipnir.valparaiso.cl Casilla 9G, Viña del Mar, Chile +56 32 672616
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
| |