Messages in this thread Patch in this message | | | Date | Sun, 12 Dec 1999 14:42:53 +0000 (GMT) | From | Eleonora Autore <> | Subject | (correction)Re: [patch] Re: 2.3.24->2.3.25 mm changes |
| |
correction to my ealier message - your patch is absolutely fine (assuming you meant brackets like these:
--- mmap.c.0 Sun Dec 12 11:46:52 1999 +++ mmap.c Sun Dec 12 14:47:53 1999 @@ -551,8 +551,7 @@ mpnt->vm_page_prot = area->vm_page_prot; mpnt->vm_flags = area->vm_flags; mpnt->vm_ops = area->vm_ops; - mpnt->vm_pgoff = area->vm_pgoff; - area->vm_pgoff += (end - area->vm_start) >> PAGE_SHIFT; + mpnt->vm_pgoff = (area->vm_pgoff + (end - area->vm_start)) >> PAGE_SHIFT; mpnt->vm_file = area->vm_file; mpnt->vm_private_data = area->vm_private_data; if (mpnt->vm_file) The "other mmap-related problems" I mentioned are in 2.3.24 also (I checked 2.3.18 and *assumed* "probably works in 2.3.24 - a few kernel versions... what is that betwixt me and thee" :)).
So, this "other" problem is that malloc(0x3000) results in a system call brk(0x4000) whilst I expect to see something like brk(0x804cdef). So it fails with ENOMEM. I will have to look at 2.3.18->2.3.24 and see whether brk(2) semantics has changed (it always had a *endds argument so I assumed it is still teh case).
Regards, Tigran.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
| |