lkml.org 
[lkml]   [1999]   [Dec]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [linux-usb] URB-ifying usb
On Wed, Dec 01, 1999, Pavel Machek <pavel@suse.cz> wrote:
> Hi!
>
> > > This patch fixes interface to between usb/uhci, makes audio actually
> > > work, and makes usb much nicer (possibility of asynchronous
> > > messages). Downside is that it will break ohci*, but fix for ohci-hcd
> > > is already available. It is pretty big change so expect minor
> > > problems; however as interface is much better I think it is
> > > neccessary.
> >
> > Please don't apply this yet. There are still some places where the API
> > is ill defined and even more important, the UHCI driver included here is
> > not safe. There are many places where it doesn't adhere to API as well
> > as race conditions in the removal of TD's.
> >
> > Pavel, I don't think the code here is quite ready for prime time.
>
> I'd hate to see 2.4.0 going out without urbs, because that would mean
> that audio would not work in any of 2.4.X. If 2.4.0 goes out with
> urbs, it still may have minor implementatino problems, but we can fix
> that in 2.4.X series, and 2.4.5 will have rock-solid usb with audio
> working. [BTW urbified uhci works pretty well for me. I see some
> problems with audio (oops after hour of usage), but that's way better
> than old usb where audio just do not work. ACM and printer work in
> both versions well.]

Please don't read into what I wrote.

I didn't say "URB's shouldn't go in before 2.4". I said "I don't think
the code is ready yet".

What that means is that I think both a) the design has a couple of
(relatively minor) issues that need to be ironed out and b) the
implementation has issues that need to be ironed out.

Right now, the current code in the kernel is more stable than the URB
code you have submitted. I don't think there are any issues that can't
be overcome, but I'd like to fix the big problems first before they go
into the kernel.

JE


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:55    [from the cache]
©2003-2011 Jasper Spaans