lkml.org 
[lkml]   [1999]   [Oct]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [patch] fbmem.c in 2.3.25-3

[Leiden, Soren]
> len = (len+~PAGE_MASK) & PAGE_MASK;
> - if (vma->vm_offset >= len) {
> + if (vma->vm_pgoff >= len) {

No, you can't just do a s/vm_offset/vm_pgoff/g -- it wasn't a simple
name-change. vm_pgoff is bit-shifted. Your patch only hides the bug.

Peter

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:54    [W:0.030 / U:0.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site