lkml.org 
[lkml]   [1999]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] cdda reading
On Mon, 11 Oct 1999, Jens Axboe wrote:

> ra.nframes would be between 1 and 8 frames before anyway. The
> 8 is wrong though, since the app might just be asking for
> 1 block. I have changed that when merging.
>

This was my biggest concern, but I noticed the other oddities, so I
brought them up.

> > Yo forgot to modify the comment to "do between 1 and 300 frames at a
> > time".
>
> We're still doing between 1 and 8 frames in each pass, but
> the app might have asked for 300 in total.
>

hrm, i guess it's time for me to look at the whole source file in scope
then, which explains the next question:

> How would that be possible? We setup the cgc command block
> every time, there's no hidden state information.
>

As i was brushing my teeth (I read mail first thing in the morning) this
occured to me. Of course, i felt stupid. More i thought about it, we'd
have to create a global-ish buffer for it, that the driver just assigned
to cgc.buffer.

eg:

void* master_buffer;
master_buffer = (void *)kmalloc(CD_FRAMESIZE_RAW*MAX_FRAMES);
/* MAX_FRAMES to avoid this confusion in the future */

...

memset(master_buffer, 0x00, CD_FRAMESIZE_RAW*MAX_FRAMES);
cgc.buffer = master_buffer;

which is not fun, as there could be potential locking issues and
it's generally messy. Sorry to ask a stupid question.
--
/jbm, but you can call me Josh. Really, you can.
"If it looks good, you'll see it.
If it sounds good, you'll hear it.
If it's marketed right, you'll buy it.
But... if it's real,
You'll Feel It." -- Kid Rock




-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:54    [W:0.045 / U:1.688 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site