Messages in this thread |  | | | Date | Thu, 28 Jan 1999 18:25:08 GMT | | From | "Stephen C. Tweedie" <> | | Subject | Re: [patch] fixed both processes in D state and the /proc/ oopses [Re: [patch] Fixed the race that was oopsing Linux-2.2.0] |
| |
Hi,
On Thu, 28 Jan 1999 10:17:37 -0800 (PST), Linus Torvalds <torvalds@transmeta.com> said:
> I'd much rather just use some stale "struct task_struct" data.
The problem isn't the risk of using stale data: it is the risk of using complete garbage if the task_struct page gets reused. The procfs code does check that tsk->mm is non-zero before following the pointers, but if there is a non-zero address there then it _will_ be dereferenced regardless.
> What we _might_ do in /proc, is to just increment the usage count for the > (double) page that contains the task structure,
That would certainly take care of it.
--Stephen
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
|  |