Messages in this thread | | | Date | Fri, 15 Jan 1999 02:31:26 -0500 (EST) | From | Alexander Viro <> | Subject | Re: [PATCH] VFAT fixes. |
| |
On Thu, 14 Jan 1999, Linus Torvalds wrote:
> unhash() > empty = check_empty() > rehash() > if (empty) > d_move()
Ummm... Typically we need to do some things that may fail after the emptiness check. Switching the parent for one. So d_move() immediately after check_empty() doesn't look right. It means one more variable and there is a plenty of them already. Oh, well... ;-/ BTW, we'll need to touch dcache.[ch] anyway - I don't see decent d_rehash() around.
> and then we can leave d_move() with the very simple semantics it has (and > that make tons of sense for files etc). > > I've put a pre-8 in "testing" on ftp.kernel.org if you'd care to look: it > does "lock_parent()" differently, and while I applied your vfat-specific > parts I didn't apply the other parts because they should be a non-issue > with pre-8 anyway (but you should verify your use of "d_move()", ok?)
OK, I'll grab pre-8 as soon as it will appear in some place I can reach (ftp.kernel.org seems to be completely unavailable). Cheers, Al
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
| |