lkml.org 
[lkml]   [1999]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectSubtle trouble in remove_bh().
Hi!

When we are already discussing the softirq.h issues here, there is another
subtle bug in remove_bh(). This one affects all boxes.

The problem is that this function first clears the handler pointer and
than clears the mask bit - if an int would occur meanwhile, it would crash
in run_bottom_halves().

jj claims that all remove_bh() calls are protected by global cli, but I
think there is one usage in drivers/scsi/scsi.c which is not...

I would suggest to change the code so it first clears the mask bit - it
costs nothing and the function does not need the global cli anymore.

Patrik


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:49    [W:0.342 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site