Messages in this thread Patch in this message | | | Date | Sun, 20 Sep 1998 16:52:14 +0200 (CEST) | From | Andrea Arcangeli <> | Subject | Re: Sound Oops in 2.1.122 |
| |
On Sun, 20 Sep 1998, Olaf Titz wrote:
>This is reproducable in 2.1.122 with sound (just plain soundblaster) >compiled as modules under the following circumstances: >let sb be autoloaded >let then sb be auto-unloaded, soundcore remains loaded >access /dev/mixer
Reproduced here too, this should fix the bug.
--- devel/kernel-tree/linux-2.1.122/drivers/sound/sb_common.c Thu Sep 17 18:43:10 1998 +++ linux/drivers/sound/sb_common.c Sun Sep 20 16:54:00 1998 @@ -592,10 +592,6 @@ sb_devc sb_info; sb_devc *devc = &sb_info; - sb_info.my_mididev = -1; - sb_info.my_mixerdev = -1; - sb_info.my_dev = -1; - /* * Initialize variables */ @@ -610,6 +606,10 @@ } memset((char *) &sb_info, 0, sizeof(sb_info)); /* Zero everything */ + sb_info.my_mididev = -1; + sb_info.my_mixerdev = -1; + sb_info.my_dev = -1; + devc->type = hw_config->card_subtype; devc->base = hw_config->io_base; @@ -954,7 +954,7 @@ if (!(devc->caps & SB_NO_AUDIO && devc->caps & SB_NO_MIDI) && devc->irq > 0) { free_irq(devc->irq, devc); - if (devc->my_mixerdev) + if (devc->my_mixerdev != -1) sound_unload_mixerdev(devc->my_mixerdev); /* We don't have to do this bit any more the UART401 is its own master -- Krzysztof Halasa */ Andrea[s] Arcangeli
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
| |