Messages in this thread | | | Date | Tue, 15 Sep 1998 09:09:18 -0700 (PDT) | From | Linus Torvalds <> | Subject | Re: gpf in do_exit |
| |
On Tue, 15 Sep 1998, Gabriel Paubert wrote: > > I did not want to speculate about this before seeing the code because > nobody should argue with God^H^H^HLinus without a good reason :-).
You had good reason.
> But I nevertheless think that you missed one case: with your patch, an > exception on popl %es in RESTORE_ALL will reset %ds to KERNEL_DS while at > this point in the code, %ds has its user mode value and it should > not be touched.
Indeed. I didn't even think of that, good point. I'll do it specially for iret, the way you originally suggested.
I also suspect I'll just get rid of "restore_all" as a common macro, because it keeps growing (bloating it up was one reason I tried to be "clever"). I'll put it in one place and just jump to it from the other ones..
Linus
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
| |