Messages in this thread |  | | | Date | Mon, 14 Sep 1998 20:18:57 +0200 | | From | Harald Koenig <> | | Subject | Re: fix for 2.1.x ni65 module bug (and other similar drivers) |
| |
On Sep 14, Alan Cox wrote:
> > browsing through more network driver sources shows that some drives > > don't initialize this name buffer, which may cause similar problems > > (btw, it's interesting (shocking?!) how many different code versions > > for the module/device initialisation can be found). > > Why.. You are forcing a block of BSS (ie all zero) to be 0..
why? only because most other drivers use the same initialzisation for their static array for device name and because I didn't know (and wasn't sure) that it's guaranteed [for all time] that these arrays are initialized with zero. as my problem showed, it's important that they _are_ initialized, so I thought better be sure...
> The quote fixes stuff is definitely right. Constant strings may not > be writable
hmm, non-writable strings would hit quite a number of network driver modules at this point...
Harald -- All SCSI disks will from now on ___ _____ be required to send an email notice 0--,| /OOOOOOO\ 24 hours prior to complete hardware failure! <_/ / /OOOOOOOOOOO\ \ \/OOOOOOOOOOOOOOO\ \ OOOOOOOOOOOOOOOOO|// Harald Koenig, \/\/\/\/\/\/\/\/\/ Inst.f.Theoret.Astrophysik // / \\ \ koenig@tat.physik.uni-tuebingen.de ^^^^^ ^^^^^ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
|  |