lkml.org 
[lkml]   [1998]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: 2.1.121 breaks compilation, initmem_freed undefined

On Sun, 13 Sep 1998, Alan Cox wrote:

> There is a function buried in the depths of the code that can be called
> from both modules and at init time. If its called at init time it
> displays the penguin logo everyone wants. If its called later it doesnt.
> So either there is a "penguin has been freed" flag or you pass "is being
> called by a module" through every single layer of code to that deeply
> buried function.

isnt it cleaner to add something like this to chdev_init:

#if defined (CONFIG_FB)
fbmem_init();
+ show_fb_logos();
#endif

this is never executed during module init. The solution is IMO not to push
a flag deep within some function, but to split the function into two
orthogonal parts. This needs no per-fbdriver #ifdefs.

-- mingo


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/faq.html

\
 
 \ /
  Last update: 2005-03-22 13:44    [from the cache]
©2003-2011 Jasper Spaans. Advertise on this site