lkml.org 
[lkml]   [1998]   [Sep]   [1]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
DateTue, 1 Sep 1998 00:26:44 -0400
SubjectBug fix for the Comtrol Rocketport driver
From tytso@mit ...
Hi Linus,

   The following patch fixes a bug in the Rocketport driver where a
signed/unsigned error caused the Rocketport driver to fail to detect a
Rocketport PCI card on certain systems (depending on whether device_fn
happened have the high bit set or not).    The fix is obvious, and has
been tested.

     Could you please apply this to for the 2.1.120 kernel, please?
Thanks!! 

     					- Ted

Patch generated: on Tue Sep  1 00:20:16 EDT 1998 by tytso@rsts-11.mit.edu
against Linux version 2.1.117

===================================================================
RCS file: drivers/char/RCS/rocket.c,v
retrieving revision 1.1
diff -u -r1.1 drivers/char/rocket.c
--- drivers/char/rocket.c	1998/09/01 04:19:44	1.1
+++ drivers/char/rocket.c	1998/09/01 04:19:56
@@ -100,8 +100,8 @@
 #include "version.h"
 #else
 #include <linux/rocket.h>
-#define ROCKET_VERSION "1.14b"
-#define ROCKET_DATE "29-Jun-98"
+#define ROCKET_VERSION "1.14c"
+#define ROCKET_DATE "24-Aug-98"
 #endif /* LOCAL_ROCKET_H */
 
 #define ROCKET_PARANOIA_CHECK
@@ -1935,7 +1935,8 @@
 #ifdef ENABLE_PCI
 #if (LINUX_VERSION_CODE < 0x020163) /* 2.1.99 */
 /* For compatibility */
-static struct pci_dev *pci_find_slot(char bus, char device_fn)
+static struct pci_dev *pci_find_slot(unsigned char bus,
+				     unsigned char device_fn)
 {
 	unsigned short		vendor_id, device_id;
 	int			ret, error;
@@ -1962,7 +1963,7 @@
 }
 #endif
      
-__initfunc(int register_PCI(int i, char bus, char device_fn))
+__initfunc(int register_PCI(int i, unsigned int bus, unsigned int device_fn))
 {
 	int	num_aiops, aiop, max_num_aiops, num_chan, chan;
 	unsigned int	aiopio[MAX_AIOPS_PER_BOARD];
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.altern.org/andrebalsa/doc/lkml-faq.html

\
 
 \ /
  Last update: 2005-03-22 13:44    [from the cache]
©2003-2008