lkml.org 
[lkml]   [1998]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: IDE-Driver Update :: Testing Requested
Hello,

> +/*
> + * This allows offboard ide-pci cards the enable a BIOS, verify interrupt

Is there any reason for enabling the expansion ROM? I don't see the
addressbios variable being access anywhere else. Anyway, if the expansion ROM
has been enabled by the BIOS, its address is already present in
dev->rom_address. If it hasn't been, you can't rely on a valid address assigned
to it.

> + pci_write_config_byte(dev, 0x30, 0x01);
> + pci_read_config_byte(dev, 0x3c, &irq1);

Please use the PCI_* macros in <linux/pci.h> for accessing standard
configuration registers. Also, use of PCI_BASE_ADDRESS_{MEM,IO}_MASK instead
of explicit masks is welcome.

Have a nice fortnight
--
Martin `MJ' Mares <mj@ucw.cz> http://atrey.karlin.mff.cuni.cz/~mj/
Faculty of Math and Physics, Charles University, Prague, Czech Rep., Earth
"Uncle Ed's Rule of Thumb: Never use your thumb for a rule."

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.altern.org/andrebalsa/doc/lkml-faq.html

\
 
 \ /
  Last update: 2005-03-22 13:44    [W:0.067 / U:1.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site