Messages in this thread | | | Subject | Re: copy_from_user() fix | From | Andi Kleen <> | Date | 23 Aug 1998 12:03:55 +0200 |
| |
In article <19980823145142.A585@castle.nmd.msu.ru>, Savochkin Andrey Vladimirovich <saw@msu.ru> writes: > --LZvS9be/3tNcYl/X > Content-Type: text/plain; charset=us-ascii
> Linus,
> I've reimplemented the fix according to Richard's suggestions.
Wouldn't it be better to do the zeroing out of line? EFAULT isn't a path worth optimizing for, and doing it with inline code in .fixup for every copy bloats the kernel a lot. I think it would be better to just put a call to a common zero function into .fixup.
As some data: my current kernel contains about 215 __copy_*_user() calls, if you only add 30 bytes per call then that is about 6KB alone.
-Andi
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.altern.org/andrebalsa/doc/lkml-faq.html
| |