Messages in this thread | | | Date | Tue, 11 Aug 1998 20:47:32 -0700 | From | "David S. Miller" <> | Subject | Re: [PATCH] de4x5.c [was Re: pre-2.1.116-1 breaks Cyrix 6x86 support] |
| |
Date: Tue, 11 Aug 1998 14:01:26 -0700 (PDT) From: Linus Torvalds <torvalds@transmeta.com>
On Tue, 11 Aug 1998, Alan Cox wrote: > > I'd be much happier with somebody finding the cause for de4x5 trying to > > probe the same device 8 times.. > > Because the kernel boot code will call "safe" probes multiple times to > look for eth1,2,3,4 for 'safe' - ie PCI/Zorro/nubus devices. So the > de4x5 init should either expect to be called up to 8 times on init or > set an internal static "just return" value
Ahh, ok. So the code is actually fine, the only part that people object to is the printout. If so, then just removing the printk's sounds like the proper solution.
What the heck is going on here? Last week the driver author himself posted a fix for this, why are we even looking into other patches for this problem at all?
Later, David S. Miller davem@dm.cobaltmicro.com
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.altern.org/andrebalsa/doc/lkml-faq.html
| |