lkml.org 
[lkml]   [1998]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Bug in ioremap: boundary case is wrong

On Sun, 26 Jul 1998, Alan Cox wrote:

> The x86 ioremap starts with
>
> if(phys_addr < virt_to_phys(high_memory))
> return phys_to_virt(phys_addr);
>
> If you vremap an area whose end point is over the high_memory point your
> memory mapping breaks. [...]

this case is sick anyway, what does it mean to have a single mapping going
across the end of memory? We should rather do:

if(phys_addr < virt_to_phys(high_memory)) {
if (phys_addr+size > high_memory)
panic("huh?");
return phys_to_virt(phys_addr);
}
-- mingo


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.altern.org/andrebalsa/doc/lkml-faq.html

\
 
 \ /
  Last update: 2005-03-22 13:43    [from the cache]
©2003-2011 Jasper Spaans