Messages in this thread | | | Date | Sun, 19 Jul 1998 01:20:55 -0400 (EDT) | From | Jon Lewis <> | Subject | Re: about syslogd and printk() |
| |
On Sun, 19 Jul 1998, Myrdraal wrote:
> > > He prints a '\n' right afterwards. That should be fine. > > It wasn't for me. I think printk's need to be \n terminated. > Look at drivers/char/sysrq.c. It does this with no ill effects.
That must be a 2.1.x thing as its not in my 2.0.34 source. Perhaps things have changed in 2.1...but non \n terminated printk's used to be trouble. I ran into this a while back when I wanted to use in_ntoa() to put 2 IP addresses in a printk, found I couldn't, then tried to split the line into 2 printk's and ended up with a messed up klogd. Thus the NIPQUAD macro was born to replace in_ntoa in printks.
------------------------------------------------------------------ Jon Lewis <jlewis@fdt.net> | Spammers will be winnuked or Network Administrator | drawn and quartered...whichever Florida Digital Turnpike | is more convenient. ______http://inorganic5.fdt.net/~jlewis/pgp for PGP public key____
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.altern.org/andrebalsa/doc/lkml-faq.html
| |