lkml.org 
[lkml]   [1998]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: Strange code in 2.0.pre35 - apricot.c
    On Sat, 11 Jul 1998 15:31:07 EDT, Alan Cox wrote:
    >> I discovered several lines like these in drivers/net/apricot.c:
    >>
    >> while (lp->scb.status, lp->scb.command)
    >>
    >> I wonder if this is a typo or intentional... It is changed in 2.1.x
    >
    > Its inentional. I dont know who broke 2.1.x

    If it's intentional, what is it supposed to do then? egcs complains that
    the left side of the expression has no effect, so it doesn't compile any
    code for it. I'm not sure about gcc 2.7.2, but if it implements a correct
    C grammer, it should do the same thing.

    When I fixed the other egcs-related warnings in the patch I sent you, I
    considered fixing apricot.c as well. I didn't touch it though, since I
    had no clue what the original author intended to do with the code..


    Ion

    --
    It is better to keep your mouth shut and be thought a fool,
    than to open it and remove all doubt.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.rutgers.edu
    Please read the FAQ at http://www.altern.org/andrebalsa/doc/lkml-faq.html

    \
     
     \ /
      Last update: 2005-03-22 13:43    [W:3.655 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site