Messages in this thread | | | From | "Adam J. Richter" <> | Date | Thu, 25 Jun 1998 21:51:24 -0700 | Subject | Re: pre-patch-2.1.107 breaks kmod |
| |
In article <6muku5$10u$1@palladium.transmeta.com> H. Peter Anvin writes: >Followup to: <Pine.LNX.3.95.980625125330.27350M-100000@penguin.transmeta.com> >By author: Linus Torvalds <torvalds@transmeta.com> >In newsgroup: linux.dev.kernel >> >> On Thu, 25 Jun 1998, Alan Cox wrote: >> > > The patch does fix a real problem, though. Some kind of re-entrancy block >> > > is needed to make sure that there aren't two copies of "insmod" trying to >> > > insert the same module at the same time. It is possible that this >> > >> > Why ? >> > >> > One of the insmod requests will fail. All that matters is that the >> > registering in module namespace is atomic, not that we load a >> > module twice and one bales >> >> Have you actually tried it? >> >> The problem is that without the lock, it _isn't_ atomic. >> >> Linus >> > >Well, that's the bug then -- loading two modules with the name name is >illegal, and *has* to work such that exactly one succeeds even if it >happens at the same time.
This would be a bug in the create_module(2) system call, not kmod or the insmod program.
-- Adam J. Richter __ ______________ 4880 Stevens Creek Blvd, Suite 205 adam@yggdrasil.com \ / San Jose, California 95129-1034 +1 408 261-6630 | g g d r a s i l United States of America fax +1 408 261-6631 "Free Software For The Rest Of Us."
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu
| |