Messages in this thread | | | From | (H. Peter Anvin) | Subject | Re: pre-patch-2.1.107 breaks kmod | Date | 25 Jun 1998 23:02:29 GMT |
| |
Followup to: <Pine.LNX.3.95.980625125330.27350M-100000@penguin.transmeta.com> By author: Linus Torvalds <torvalds@transmeta.com> In newsgroup: linux.dev.kernel > > On Thu, 25 Jun 1998, Alan Cox wrote: > > > The patch does fix a real problem, though. Some kind of re-entrancy block > > > is needed to make sure that there aren't two copies of "insmod" trying to > > > insert the same module at the same time. It is possible that this > > > > Why ? > > > > One of the insmod requests will fail. All that matters is that the > > registering in module namespace is atomic, not that we load a > > module twice and one bales > > Have you actually tried it? > > The problem is that without the lock, it _isn't_ atomic. > > Linus >
Well, that's the bug then -- loading two modules with the name name is illegal, and *has* to work such that exactly one succeeds even if it happens at the same time.
-hpa -- PGP: 2047/2A960705 BA 03 D3 2C 14 A8 A8 BD 1E DF FE 69 EE 35 BD 74 See http://www.zytor.com/~hpa/ for web page and full PGP public key I am Bahá'í -- ask me about it or see http://www.bahai.org/ "To love another person is to see the face of God." -- Les Misérables
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu
| |