lkml.org 
[lkml]   [1998]   [Apr]   [20]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateMon, 20 Apr 1998 13:07:57 +0200
FromMartin Mares <>
SubjectRe: Fix for PCI detection in fdomain.c
Hi,

   Scanning the PCI busses directly as you do in your patch is both ugly and
non-portable. We should find a better solution, preferably debug my original
probing code which makes use of the generic PCI layer.

> + ***  19 Apr 1998: As James T. McKinley wrote above, there is a problem
> +      with the Future Domain hardware that prevents pcibios_find_device
> +      (now pci_find_device) from operating properly.  Following is the
> +      device call properly implemented by Martin Mares:
> + 
> +  if ((pdev = pci_find_device(PCI_VENDOR_ID, PCI_DEVICE_ID_FD_36C70, pdev)) == NULL)
> +    return 0;
> +
> +      Unfortunately, it always returns NULL on my Adaptec 2920 SCSI host
> +      adaptor.  James reported to me that several people have written him
> +      about the problem with the new driver, so here is the original loop
> +      routine that he wrote to detect the PCI adaptors properly.

   Yes, it _must_ always return NULL as you've misspelled my misspelling fix I've
sent you. The correct line is:

   if ((pdev = pci_find_device(PCI_VENDOR_ID_FD, PCI_DEVICE_ID_FD_36C70, pdev)) == NULL)
and it should be present in 2.1.97. Please test that.

				Have a nice fortnight
-- 
Martin `MJ' Mares   <mj@ucw.cz>   http://atrey.karlin.mff.cuni.cz/~mj/
Faculty of Math and Physics, Charles University, Prague, Czech Rep., Earth
"In accord to UNIX philosophy, PERL gives you enough rope to hang yourself." -- Larry Wall

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu

\
 
 \ /
  Last update: 2005-03-22 13:42    [from the cache]
©2003-2008