Messages in this thread Patch in this message | | | Subject | [2.1.98] two small fixes for ad1848.c | Date | Thu, 16 Apr 1998 03:48:19 +0300 | From | Dominik Kubla <> |
| |
While compiling the sound driver for the builtin MSS of my DEC MULTIA, i noticed some warnings about casts from ptr to int. No big deal on 32bit systems, but on 64bit systems i learned to check these warnings.
Also the code does not look dangerous, it still looked suspicious to me and i decided to change the variables/casts in question from "int" to "long". Recompilation went without a glitch and so far the system has not crashed, but i have not yet tested the sound driver... Where is that .au-file when you need it?
Anyway i feel confident enough to submit the patch before i finally go to bed... (So it gets out with the morning mail) :-)
Yours, Dominik Kubla
--- linux/drivers/sound/ad1848.c.orig Mon Apr 13 22:56:36 1998 +++ linux/drivers/sound/ad1848.c Wed Apr 15 23:45:38 1998 @@ -1721,7 +1721,7 @@ */ - int my_dev; + long my_dev; char dev_name[100]; int e; @@ -1950,12 +1950,12 @@ { unsigned char status; ad1848_info *devc; - int dev; + long dev; int alt_stat = 0xff; unsigned char c930_stat = 0; int cnt = 0; - dev = (int)dev_id; + dev = (long)dev_id; devc = (ad1848_info *) audio_devs[dev]->devc; interrupt_again: /* Jump back here if int status doesn't reset */ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu
| |