lkml.org 
[lkml]   [1998]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: advancsys scsi driver broken in 2.1.96-pre 1
On Mon, 13 Apr 1998, Joseph Skinner wrote:

> Hi all
>
> I just tried to compile the latest kernel and found that the advancsys
> driver seem to be broken. I get the following errors from tje compile.
...
I could compile advansys and fdomain scsi driver as modules with following
patch. It just moves forward Declarations about do_xxxxxxxx_intr(rupt) before
such codes which emits warnings. Though, I am not convinced of the accuracy
of it. This is against 2.1.96pre1.

diff -u -r --new-file vanilla/linux/drivers/scsi/advansys.c linux/drivers/scsi/advansys.c
--- vanilla/linux/drivers/scsi/advansys.c Mon Apr 13 22:17:58 1998
+++ linux/drivers/scsi/advansys.c Mon Apr 13 22:36:19 1998
@@ -3850,6 +3848,17 @@
#if LINUX_VERSION_CODE >= ASC_LINUX_VERSION(1,3,89)
STATIC void advansys_select_queue_depths(struct Scsi_Host *,
Scsi_Device *);
+#if LINUX_VERSION_CODE >= ASC_LINUX_VERSION(2,1,95)
+static void
+do_advansys_interrupt(int irq, void *dev_id, struct pt_regs *regs)
+{
+ unsigned long flags;
+
+ spin_lock_irqsave(&io_request_lock, flags);
+ advansys_interrupt(irq, dev_id, regs);
+ spin_unlock_irqrestore(&io_request_lock, flags);
+}
+#endif
#endif /* version >= v1.3.89 */
STATIC void advansys_command_done(Scsi_Cmnd *);
STATIC void asc_scsi_done_list(Scsi_Cmnd *);
@@ -6211,18 +6220,6 @@
ASC_DBG(1, "advansys_interrupt: end\n");
return;
}
-
-#if LINUX_VERSION_CODE >= ASC_LINUX_VERSION(2,1,95)
-static void
-do_advansys_interrupt(int irq, void *dev_id, struct pt_regs *regs)
-{
- unsigned long flags;
-
- spin_lock_irqsave(&io_request_lock, flags);
- advansys_interrupt(irq, dev_id, regs);
- spin_unlock_irqrestore(&io_request_lock, flags);
-}
-#endif

#if LINUX_VERSION_CODE >= ASC_LINUX_VERSION(1,3,89)
/*
diff -u -r --new-file vanilla/linux/drivers/scsi/fdomain.c linux/drivers/scsi/fdomain.c
--- vanilla/linux/drivers/scsi/fdomain.c Mon Apr 13 22:17:59 1998
+++ linux/drivers/scsi/fdomain.c Mon Apr 13 16:56:15 1998
@@ -948,6 +948,15 @@
} else {
/* Register the IRQ with the kernel */

+void do_fdomain_16x0_intr( int irq, void *dev_id, struct pt_regs * regs )
+{
+ unsigned long flags;
+
+ spin_lock_irqsave(&io_request_lock, flags);
+ fdomain_16x0_intr(irq, dev_id, regs);
+ spin_unlock_irqrestore(&io_request_lock, flags);
+}
+
retcode = request_irq( interrupt_level,
do_fdomain_16x0_intr, SA_INTERRUPT, "fdomain", NULL);

@@ -1609,15 +1618,6 @@
in_interrupt_flag = 0;
#endif
return;
-}
-
-void do_fdomain_16x0_intr( int irq, void *dev_id, struct pt_regs * regs )
-{
- unsigned long flags;
-
- spin_lock_irqsave(&io_request_lock, flags);
- fdomain_16x0_intr(irq, dev_id, regs);
- spin_unlock_irqrestore(&io_request_lock, flags);
}

int fdomain_16x0_queue( Scsi_Cmnd * SCpnt, void (*done)(Scsi_Cmnd *))

"Where there is a will, there is a way." jinbo21@soback.kornet.nm.kr
kbeyl@kids.kotel.co.kr
For the future of you and me! hitel: jinbo21


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu

\
 
 \ /
  Last update: 2005-03-22 13:42    [W:0.041 / U:0.552 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site