Messages in this thread | | | Date | Sun, 12 Apr 1998 00:19:37 -0600 | From | Erik Andersen <> | Subject | Re: arch/arm/config.in: CONFIG_CDROM is obsolete |
| |
On Sun, Apr 12, 1998 at 12:36:36AM -0500, Michael Elizabeth Chastain wrote: > Hi guys, > > I'm catching up on recent patches and I see the following block > of code in patch-2.1.94: > > # arch/arm/config.in > +# Conditionally compile in the Uniform CD-ROM driver > +if [ "$CONFIG_BLK_DEV_IDECD" = "y" -o "$CONFIG_BLK_DEV_SR" = "y" ]; then > + define_bool CONFIG_CDROM y > +else > + if [ "$CONFIG_BLK_DEV_IDECD" = "m" -o "$CONFIG_BLK_DEV_SR" = "m" ]; then > + define_bool CONFIG_CDROM m > + else > + define_bool CONFIG_CDROM n > + fi > +fi > + > > This is obsolete -- the newly rewritten drivers/cdrom/Makefile doesn't > need the composite symbol CONFIG_CDROM any more. So I believe this block > can go away. Also the default definition of CONFIG_CDROM in > arch/arm/defconfig can go away too. > > Execute this command to see that CONFIG_CDROM is vestigial: > > egrep CONFIG_CDROM `find . -type f -print | sort` > > I wish I had time to make a patch but I only have enough time to file a > report. > > Regards, > > Michael Chastain > <mailto:mec@shout.net> > "love without fear"
Thanks for the tip. I will be glad to fix this one up in my upcoming set of patches...
-Erik
-- Erik B. Andersen Web: http://www.inconnect.com/~andersen/ email: andersee@debian.org --This message was written using 73% post-consumer electrons--
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu
| |