Messages in this thread | | | From | Jakub Jelinek <> | Subject | s_last_mounted in EXT2 | Date | Tue, 10 Mar 1998 08:41:13 +0100 (MET) |
| |
Hi!
Shouldn't we actually start using s_last_mounted field in ext2 filesystems? I am not sure if it is a good idea to write s_last_mounted even if s_rev_level is EXT2_GOOD_OLD_REV, but if it is EXT2_DYNAMIC_REV and up, I think we must fill it - with dentries it is fairly easy. What I'm just not sure: a) whether someone wrote it already b) how to actually do it: I think it is best to update it at umount time, but at the time of put_super it is too late (s_root is lost already). So one solution might be e.g. to add another super_operation, something like note_last_mounted(sb) which would be called from d_umount.
BTW: I'm wondering why are routines like d_umount, umount_dev (ie. short static routines references just once in the code) not __inline__? Is there any reason why? Is there any architecture where it generates bad code? A lot of similar stuff is in sched.c and others...
Cheers, Jakub ___________________________________________________________________ Jakub Jelinek | jj@sunsite.mff.cuni.cz | http://sunsite.mff.cuni.cz Administrator of SunSITE Czech Republic, MFF, Charles University ___________________________________________________________________ Ultralinux - first 64bit OS to take full power of the UltraSparc Linux version 2.1.89 on a sparc64 machine (498.80 BogoMips). ___________________________________________________________________
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu
| |