Messages in this thread | | | Date | Tue, 17 Feb 1998 20:29:07 -0800 (PST) | From | Linus Torvalds <> | Subject | Re: Patch for sound CS4232 on 2.1.87 |
| |
On Tue, 17 Feb 1998, Eric Leblanc wrote: > > Just a patch for compiling CS4232 PnP soundcard. The Makefile forgot to > compile the a/d which is needed by the card. > > diff -u --recursive --new-file linux-2.1.87/drivers/sound/Makefile linux/drivers/sound/Makefile > --- linux-2.1.87/drivers/sound/Makefile Tue Feb 17 15:59:52 1998 > +++ linux/drivers/sound/Makefile Tue Feb 17 23:09:41 1998 > @@ -183,10 +183,10 @@ > endif > > ifeq ($(CONFIG_CS4232),y) > -LX_OBJS += cs4232.o > +LX_OBJS += cs4232.o ad1848.o > else > ifeq ($(CONFIG_CS4232),m) > - MX_OBJS += cs4232.o > + MX_OBJS += cs4232.o ad1848.o > endif > endif
There must be something wrong with this. Essentially, the sound configuration or the makefile appear broken: with certain configurations the "ad1848" files would show up multiple times, which cannot be what this should be all about.
I strongly suspect that the bug is not in the Makefile, and that the above patch only tries to fix the symptoms rather than the real problem. It _looks_ like the real fix is to force the configuration to always configure "CONFIG_MSS" which should do the correcy thing with the ad1848 file, rather than have the Makefile know about the file in multiple places.
In short, I'd like the issue to be clarified by somebody who uses sound and routinely compiles multiple modules etc before I'd feel comfortable with applying this patch...
Linus
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu
| |