Messages in this thread | | | Date | Mon, 7 Dec 1998 18:00:03 +0100 (CET) | From | Geert Uytterhoeven <> | Subject | Re: An obvious patch |
| |
On 7 Dec 1998, Andreas Schwab wrote: > --- linux/net/sunrpc/xdr.c.~1~ Wed Apr 9 21:29:26 1997 > +++ linux/net/sunrpc/xdr.c Sun Dec 6 14:28:57 1998 > @@ -13,39 +13,9 @@ > #include <linux/sunrpc/xdr.h> > #include <linux/sunrpc/msg_prot.h> > > -u32 rpc_success, rpc_prog_unavail, rpc_prog_mismatch, rpc_proc_unavail, > - rpc_garbage_args, rpc_system_err; > -u32 rpc_auth_ok, rpc_autherr_badcred, rpc_autherr_rejectedcred, > - rpc_autherr_badverf, rpc_autherr_rejectedverf, rpc_autherr_tooweak; > -u32 xdr_zero, xdr_one, xdr_two; > - > void > xdr_init(void) > { > - static int inited = 0; > - > - if (inited) > - return; > - > - xdr_zero = htonl(0); > - xdr_one = htonl(1); > - xdr_two = htonl(2); > - > - rpc_success = htonl(RPC_SUCCESS); > - rpc_prog_unavail = htonl(RPC_PROG_UNAVAIL); > - rpc_prog_mismatch = htonl(RPC_PROG_MISMATCH); > - rpc_proc_unavail = htonl(RPC_PROC_UNAVAIL); > - rpc_garbage_args = htonl(RPC_GARBAGE_ARGS); > - rpc_system_err = htonl(RPC_SYSTEM_ERR); > - > - rpc_auth_ok = htonl(RPC_AUTH_OK); > - rpc_autherr_badcred = htonl(RPC_AUTH_BADCRED); > - rpc_autherr_rejectedcred = htonl(RPC_AUTH_REJECTEDCRED); > - rpc_autherr_badverf = htonl(RPC_AUTH_BADVERF); > - rpc_autherr_rejectedverf = htonl(RPC_AUTH_REJECTEDVERF); > - rpc_autherr_tooweak = htonl(RPC_AUTH_TOOWEAK); > - > - inited = 1; > }
Why not get rid of xdr_init() completely, or replace it by a #define in some header file? :-)
#define xdr_init generic_empty_function
Greetings,
Geert
-- Geert Uytterhoeven Geert.Uytterhoeven@cs.kuleuven.ac.be Wavelets, Linux/{m68k~Amiga,PPC~CHRP} http://www.cs.kuleuven.ac.be/~geert/ Department of Computer Science -- Katholieke Universiteit Leuven -- Belgium
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
| |