lkml.org 
[lkml]   [1998]   [Dec]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: m68k softirq.h fix
Date
From
> Hi all,
>
> Yet another fix. bh_mask_count is an array of atomic_t, which
> is a struct with a single int variable called counter. I assume this
> patch is correct and is the original intent of the code.
>
> -- DN (No, I still have no idea what I'm doing. But it compiles! <g>)

Sure it does compile, but it is wrong.
See model from AC's patches:

ftp://ftp.uk.linux.org/pub/linux/alan/2.1/patch-2.1.132-ac2.bz2

see 'softirq.h' files in it.
For the idea WHY your code is wrong, see Alpha's definitions
for atomic_inc(), and friends. You must not go setting,
or (heaven forbid), blindly ++:ing fields in there!

/Matti Aarnio <matti.aarnio@sonera.fi>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:46    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site