Messages in this thread | | | Date | Fri, 18 Dec 1998 07:35:00 -0800 (PST) | From | Linus Torvalds <> | Subject | Re: pre-2.1.132-2.. |
| |
On Fri, 18 Dec 1998, MOLNAR Ingo wrote: > > NO! :) On SMP, with shared data structures, we want to have 1 structure > per cacheline, otherwise we'd just play cacheline ping-pong for no good > reason.
Note that we probably don't have a cache-line per CPU anyway, because there is nothing to force proper alignment of the irq_desc[] array.
> (the padding is wrong in both cases btw, unless i cant count (damn, where > was that calculator). We need unused[5])
Strange counting.
Anyway, currently the alignment is wrong, and the size is wrong. The size is wrong because the original structure looked different, and one of the changes must have messed that up. Oh, well.
I suspect that we could actually get rid of the padding altogether, and align it to a 16-byte boundary. Then it wouldn't be cache-line aligned, but it _would_ be half-cache-line aligned and thus at least partly minimize the overhead.
Linus
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
| |