lkml.org 
[lkml]   [1998]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Re: BUG in rmdir changes


On Sat, 12 Dec 1998, Mike Galbraith wrote:

> No, I see it too. Staring at the changes which let do this, it looks
> like a couple of dputs got left behind for this error case. I tested
> the below on ext2 and knfs.. all seems fine now.
>
> It would be nice if a dcache-smart person would look at this 'fix'.
>
> --- linux-2.1.131.virgin/fs/namei.c Thu Dec 10 15:37:04 1998
> +++ linux-2.1.131.work/fs/namei.c Sat Dec 12 10:44:09 1998
> @@ -880,7 +880,11 @@
>
> error = -ENOENT;
> if (!dentry->d_inode)
> + {
> + dput(dentry);
> + dput(dir);
> goto exit;
> + }

Good idea, but there is a simpler one: move dget() below the test.
dput(dir) is outright wrong - you'll confuse the hell of the dcache.
Anyway, *this* bug is fixed in ac9 and I can post a complete patch against
2.1.131 here (it's ~44K) if anybody wants.
Al
--
There are no "civil aviation for dummies" books out there and most of
you would probably be scared and spend a lot of your time looking up
if there was one. :-) Jordan Hubbard in c.u.b.f.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:46    [from the cache]
©2003-2011 Jasper Spaans