lkml.org 
[lkml]   [1998]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: delayed acks after fast recover
   Date: Mon, 30 Nov 1998 20:44:25 +0100 (CET)
From: Andrea Arcangeli <andrea@e-mind.com>

>One problem I have so far though:
>
>@@ -129,7 +166,7 @@
> tp->delayed_acks++;
> /* Tiny-grams with PSH set make us ACK quickly. */
> if(th->psh && (skb->len < (tp->mss_cache >> 1)))
>- tp->ato = HZ/50;
>+ tp->delack_mode |= TCP_DELACK_DISABLE;
> }
>
> /* Called to compute a smoothed rtt estimate. The data fed to this
>
>This is wrong, I don't like this. The code wants to ack "quickly" not
>"right now" in these cases. There is an example case I once saw in a

quickly == right now over my ppp link ;).

Over your ppp link, right now vs. HZ/50 won't make one single difference.

Probably is better to remove the whole check for pushed little
segments if you care to decrease the network load.

It doesn't work like that. There are many cases where this heuristic
improves responsiveness substantially and many people cried before I
put it in (2.0.x does something like this too).

Later,
David S. Miller
davem@dm.cobaltmicro.com

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:45    [W:0.040 / U:6.932 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site