lkml.org 
[lkml]   [1998]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: delayed acks after fast recover
On Mon, 30 Nov 1998, David S. Miller wrote:

>Ok I am looking at this patch. But I will take a lot of time with it,

OK.

>One problem I have so far though:
>
>@@ -129,7 +166,7 @@
> tp->delayed_acks++;
> /* Tiny-grams with PSH set make us ACK quickly. */
> if(th->psh && (skb->len < (tp->mss_cache >> 1)))
>- tp->ato = HZ/50;
>+ tp->delack_mode |= TCP_DELACK_DISABLE;
> }
>
> /* Called to compute a smoothed rtt estimate. The data fed to this
>
>This is wrong, I don't like this. The code wants to ack "quickly" not
>"right now" in these cases. There is an example case I once saw in a

quickly == right now over my ppp link ;). Probably is better to remove the
whole check for pushed little segments if you care to decrease the network
load.

Andrea Arcangeli


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:45    [W:0.058 / U:1.828 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site