lkml.org 
[lkml]   [1998]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subjectsbusfb problems (and a patch)
I was just trying 2.1.125 (from vger) on my sparc (ss2, cg6 fb), and found
several problems. Only one process was allowed to open the framebuffer
device at a time, and mmaping it causes a lockup at line 256 in sbusfb.c.
If I comment out that line (which looks like it is intended to turn off
the text cursor), there is no crash, but writing to the mmap'd area has no
visible result. (Seeking around in /dev/fb0 and writing works fine,
btw). I don't know if sbusfb_mmap ever worked, so I'm not sure where to
start in trying to fix it.. I've attached a patch for the sbusfb_{open,close} problem.--- linux.old/drivers/video/sbusfb.c Sat Oct 3 16:12:37 1998
+++ linux/drivers/video/sbusfb.c Thu Oct 8 12:08:39 1998
@@ -128,9 +128,7 @@
struct fb_info_sbusfb *fb = sbusfbinfo(info);

if (user) {
- if (fb->open) return -EBUSY;
- fb->mmaped = 0;
- fb->open = 1;
+ fb->open++;
fb->vtconsole = -1;
} else
fb->consolecnt++;
@@ -152,7 +150,7 @@
}
if (fb->reset)
fb->reset(fb);
- fb->open = 0;
+ fb->open--;
} else
fb->consolecnt--;
MOD_DEC_USE_COUNT;
\
 
 \ /
  Last update: 2005-03-22 13:44    [from the cache]
©2003-2011 Jasper Spaans