lkml.org 
[lkml]   [1998]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [patch] my latest oom stuff
From
Date
In article <Pine.LNX.3.96.981024185739.1080H-100000@penguin.transmeta.com>,
Linus Torvalds <torvalds@transmeta.com> writes:

> But I suspect that the REAL bug is that there may be code-paths that busy
> loop forever if they get NULL from __get_free_pages(). That's bad. We
> found and fixed one in the TCP code earlier, and the way to figure them

I'm not sure to what TCP code path you were refering to, but
tcp_send_active_reset() still contains this code:

do {
skb = alloc_skb(MAX_HEADER + sk->prot->max_header, GFP_KERNEL);
} while(skb == NULL);

I think it should be fixed, because it doesn't matter much if the RST gets
dropped or not (if the other end sends new data or goes into window
probing it will force a new RST later anyways)


-Andi

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:45    [W:0.198 / U:2.804 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site