Messages in this thread | | | Date | Mon, 19 Oct 1998 00:21:19 -0400 (EDT) | From | William Stearns <> | Subject | Re: Linux 2.1.126pre2ac1 |
| |
On Sun, 18 Oct 1998, Horst von Brand wrote:
> alan@lxorguk.ukuu.org.uk (Alan Cox) said: > > [...] > > > Unpack 2.1.125, patch with Linus diff then patch with mine, build and enjoy, > > report bugs. > > You asked for it. This variable turns out never to be defined: > > --- linux/drivers/char/pc_keyb.c-2.1.126pre2ac1 Sun Oct 18 14:27:12 1998 > +++ linux/drivers/char/pc_keyb.c Sun Oct 18 15:26:23 1998 > @@ -41,6 +41,8 @@ > > #include "pc_keyb.h" > > +unsigned char pckbd_read_mask; > +
2.1.126pre1 and pre2 both remove the following line from pc_keyb.c:
unsigned char pckbd_read_mask = KBD_STAT_OBF; /* Modified by psaux.c */
As I usually use a ps/2 mouse, 2.1.126pre1 and 2 fail to compile at all - the final link fails with:
kernel/kernel.o(__ksymtab+0x7d8): undefined reference to `pckbd_read_mask'
Is it simply a matter of changing: extern unsigned char aux_device_present, pckbd_read_mask; to extern unsigned char aux_device_present; in kernel/ksyms.c?
I've already sent off a note about this to Johan Myreen, the person who appeared to have made the changes to pc_keyb.c. I didn't CC linux-kernel as I though the problem might be that only part of Johan's patch made it into 2.1.126pre[12]; I wanted to wait for the next one from Linus. Cheers, - Bill
--------------------------------------------------------------------------- Unix _is_ user friendly. It's just very selective about who its friends are. And sometimes even best friends have fights. William Stearns (wstearns@pobox.com) Mason, buildkernel, and named2hosts are at: http://www.pobox.com/~wstearns ---------------------------------------------------------------------------
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
| |