Messages in this thread | | | Date | Mon, 12 Jan 1998 13:17:12 -0500 | From | mlord <> | Subject | Re: IDE Device blacklist in drivers/block/ide_modes.h |
| |
Derrik Pates wrote: > > I was going through old e-mails, and noticed that breakage of the > blacklist comparison has been noted in the kernel.
Really? Anybody want to tell me about this?
> and noticed that the same issue was still present. I am including a diff > against the kernel (This is against 2.1.78, but I believe it's simple
Diff is buggy. Do not use. ... > ! if (strncmp(p->name, model, strlen(p->name)) == 0) ... > ! len[0] = strlen(p->name); > ! len[1] = strlen(model);
The problem is that "model" is not necessarily a zero-terminated string, so doing a strlen() on it may segfault (unlikely), or result in a bad comparism.
-- mlord@pobox.com The Linux IDE guy
| |